tls: fix to send TLS Alert before socket destroyed #7961

shigeki · 2014-07-17T14:29:09Z

When TLS Alert is occured in handshake, ClearOut only write it into wbio and does not flush to socket. TLS Alert should be written to socket with EncOut before socket is destroyed within its error callback.
After this patch, TLS Alert surly is sent from node server which is limited to accept TLS1.2 as below

$ openssl s_client -quiet -tls1_1  -connect localhost:443
140321003767456:error:1409442E:SSL routines:ssl3_read_bytes:tlsv1 alert protocol version:s3_pkt.c:1554:SSL alert number 70
140321003767456:error:1409E0E5:SSL routines:ssl3_write_bytes:ssl handshake failure:s3_pkt.c:658:

When TLS Alert is occured in handshake, ClearOut only write it into wbio and does not flush to socket. TLS Alert should be written to socket with EncOut before socket is destroyed within its error callback.

indutny · 2014-07-23T19:44:16Z

Landed in 2bb4867, thank you!

tls: fix to send TLS Alert before socket destroyed

3d7e3de

When TLS Alert is occured in handshake, ClearOut only write it into wbio and does not flush to socket. TLS Alert should be written to socket with EncOut before socket is destroyed within its error callback.

indutny closed this Jul 23, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tls: fix to send TLS Alert before socket destroyed #7961

tls: fix to send TLS Alert before socket destroyed #7961

shigeki commented Jul 17, 2014

indutny commented Jul 23, 2014

tls: fix to send TLS Alert before socket destroyed #7961

tls: fix to send TLS Alert before socket destroyed #7961

Conversation

shigeki commented Jul 17, 2014

indutny commented Jul 23, 2014